Skip to content

method input_password() docstring has been supplemented. - #358

Closed
stasiek wants to merge 1 commit into
robotframework:masterfrom
stasiek:master
Closed

stasiek wants to merge 1 commit into
robotframework:masterfrom
stasiek:master

Conversation

@stasiek

@stasiek stasiek commented Feb 9, 2015

Copy link
Copy Markdown

Since it's a known issue ( #202 ) it should at least be mentioned in the docstring.

@emanlove

emanlove commented Feb 9, 2015

Copy link
Copy Markdown
Member

I agree this should be in the docstring but you should clarify under which scenarios it shows up, that is when using loglevel DEBUG. Otherwise it is confusing to say "it does not log it" but than say "it is in the report file" as those statements seem contradictory.

@aaltat

aaltat commented Dec 29, 2016

Copy link
Copy Markdown
Contributor

We are planning some architecture changes. This architecture change will most likely change the current code base in such way that the PR will cause conflicts and therefore cannot be merged directly to the master.

We don't have a excat date for the architecture change, but most likely it will happen in early next year. If you want this PR to be merged in the master before the architecture change, now is the time to improve the PR and get it merged to the master.

@aaltat

aaltat commented Nov 8, 2017

Copy link
Copy Markdown
Contributor

This is closed because of #984

@aaltat aaltat closed this Nov 8, 2017
@pekkaklarck

Copy link
Copy Markdown
Member

More precisely commit 550ebaa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants